Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support out-dir in build section of Cargo configuration file #7810

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Support out-dir in build section of Cargo configuration file #7810

merged 1 commit into from
Jan 27, 2020

Conversation

giraffate
Copy link
Contributor

Fixed #7555.

@rust-highfive
Copy link

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2020
@alexcrichton alexcrichton added the T-cargo Team: Cargo label Jan 17, 2020
@alexcrichton
Copy link
Member

@rfcbot fcp merge

Seems like a reasonable feature to me! Canvassing the rest of the team to double check as well.

@rfcbot
Copy link
Collaborator

rfcbot commented Jan 17, 2020 •
edited by ehuss
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge labels Jan 17, 2020
@joshtriplett
Copy link
Member

Seems reasonable to me.

@rfcbot reviewed

@rfcbot rfcbot added final-comment-period FCP — a period for last comments before action is taken and removed proposed-final-comment-period An FCP proposal has started, but not yet signed off. labels Jan 17, 2020
@rfcbot
Copy link
Collaborator

rfcbot commented Jan 17, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period FCP complete and removed final-comment-period FCP — a period for last comments before action is taken labels Jan 27, 2020
@rfcbot
Copy link
Collaborator

rfcbot commented Jan 27, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jan 27, 2020

📌 Commit 4a1ba1c has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2020
@bors
Copy link
Collaborator

bors commented Jan 27, 2020

⌛ Testing commit 4a1ba1c with merge c326fcb...

bors added a commit that referenced this pull request Jan 27, 2020
@bors
Auto merge of #7810 - giraffate:support_out_dir_in_build_section, r=a…
c326fcb 
…lexcrichton

Support out-dir in build section of Cargo configuration file

Fixed #7555.
@bors
Copy link
Collaborator

bors commented Jan 27, 2020

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing c326fcb to master...

@bors bors merged commit 4a1ba1c into rust-lang:master Jan 27, 2020
@giraffate giraffate deleted the support_out_dir_in_build_section branch January 29, 2020 00:50
@ehuss ehuss added this to the 1.43.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
disposition-merge FCP with intent to merge finished-final-comment-period FCP complete S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-cargo Team: Cargo
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.

Support out-dir in [build] section of Cargo configuration
7 participants
@giraffate @rust-highfive @alexcrichton @rfcbot @joshtriplett @bors @ehuss